Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: OpenFEPOPS: A Python implementation of the FEPOPS molecular similarity technique #5746

Closed
editorialbot opened this issue Aug 8, 2023 · 24 comments
Assignees
Labels
HTML JavaScript Makefile pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 8, 2023

Submitting author: @stevenshave (Steven Shave)
Repository: https://github.com/JustinYKC/FEPOPS
Branch with paper.md (empty if default branch):
Version: 1.4.0
Editor: @richardjgowers
Reviewers: @hannahbaumann, @exs-cbouy
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b4ab6027d3eca941ca7b3ffc70e636d8"><img src="https://joss.theoj.org/papers/b4ab6027d3eca941ca7b3ffc70e636d8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b4ab6027d3eca941ca7b3ffc70e636d8/status.svg)](https://joss.theoj.org/papers/b4ab6027d3eca941ca7b3ffc70e636d8)

Author instructions

Thanks for submitting your paper to JOSS @stevenshave. Currently, there isn't a JOSS editor assigned to your paper.

@stevenshave if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Aug 8, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.09 s (707.9 files/s, 154189.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            17            714             48           5165
SVG                              1              0              0           2671
Python                          15            307            613           1555
JavaScript                      12            131            213            871
CSS                              4            185             35            762
YAML                             3              2              4            172
TeX                              1             11              0            113
Markdown                         3             28              0            108
TOML                             1              5              0             47
reStructuredText                 5             33             53             39
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            64           1428            974          11538
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 835

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.jmgm.2007.02.005 may be a valid DOI for title: Flexible 3D pharmacophores as descriptors of dynamic biological space
- 10.1021/jm049654z may be a valid DOI for title: A 3D similarity method for scaffold hopping from known drugs or natural ligands to new chemotypes
- 10.1002/9783527665143.ch10 may be a valid DOI for title: Feature Point Pharmacophores (FEPOPS)
- 10.1016/j.drudis.2011.02.011 may be a valid DOI for title: State-of-the-art in ligand-based virtual screening
- 10.1111/j.1476-5381.2010.01127.x may be a valid DOI for title: Principles of early drug discovery
- 10.1186/s13321-020-00444-5 may be a valid DOI for title: QSAR-derived affinity fingerprints (part 2): modeling performance for potency prediction
- 10.1021/jm300687e may be a valid DOI for title: Directory of useful decoys, enhanced (DUD-E): better ligands and decoys for better benchmarking
- 10.1186/1758-2946-4-27 may be a valid DOI for title: USRCAT: real-time ultrafast shape recognition with pharmacophoric constraints
- 10.1016/j.eswa.2008.01.039 may be a valid DOI for title: A simple and fast algorithm for K-medoids clustering

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @richardjgowers as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@stevenshave
Copy link

Hello! I will be making an update to the publication to include benchmarking results, address the missing DOIs and fix API docs imminently. Many thanks, Steve

@richardjgowers
Copy link

@editorialbot assign @richardjgowers as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @richardjgowers is now the editor

@stevenshave
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @stevenshave, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@stevenshave
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@stevenshave
Copy link

Hi @richardjgowers, I have now made updates to the repo including API docs, userguide and added benchmark results to the paper. Suggested DOIs have been added to my paper.bib, but some referenced articles have no valid DOI. Please let me know the next steps. Many thanks, Steve

@richardjgowers
Copy link

@stevenshave thanks. Th process going forwards will be I'll be looking for some reviewers and invite them here, then a new github issue for the review process will be created.

@richardjgowers
Copy link

@cbouy would you be interested in review this?

@richardjgowers
Copy link

@editorialbot add @hannahbaumann as reviewer

@editorialbot
Copy link
Collaborator Author

@hannahbaumann added to the reviewers list!

@cbouy
Copy link

cbouy commented Aug 16, 2023

@richardjgowers Sure, I'll use my other account handle for this if possible: @exs-cbouy

@richardjgowers
Copy link

@editorialbot add @exs-cbouy as reviewer

@editorialbot
Copy link
Collaborator Author

@exs-cbouy added to the reviewers list!

@richardjgowers
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTML JavaScript Makefile pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

5 participants