-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: pynucastro: an interface to nuclear reaction rates and code generator for reaction network equations #588
Comments
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @kyleniemeyer it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
OK, the reviewer is @jschwab |
@jschwab you are the second reviewer and we are hoping you can contribute your particular expertise in nuclear astrophysics to this review. See below for instructions. (please note that first reviewer @kyleniemeyer has received his own set of instructions, and checklist, above). Reviewer instructions & questions@jschwab, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @katyhuff know. Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Okay, just started the review. I made it through the README and opened pynucastro/pynucastro#30, pynucastro/pynucastro#31, pynucastro/pynucastro#32, pynucastro/pynucastro#33. |
Thanks Josiah! I'll make my way through these issues, I appreciate your careful feedback thus far and I look forward to your review. |
I made it through the "Software paper" and that part looks good to me (fixed a few typos in pynucastro/pynucastro#37). There's no DOI for Zingale et al. 2017 but it is on arXiv (and I'm guessing it will get a DOI in the future?). The BibTeX entry and bib style mean that it doesn't get a hyperlink. For now, perhaps just change adsurl -> url for that entry in the .bib to give it something clickable? |
@whedon commands |
Here are some things you can ask me to do:
|
@whedon generate pdf |
|
@whedon generate pdf |
|
Thanks @jschwab for the note about the url for the Zingale 2017 paper, which should get a DOI at some point when it is officially published. I've made the link clickable using the Thank you as well for fixing the typos you've found! |
@katyhuff @dwillcox @zingale I'm pleased to recommend that the pynucastro paper be accepted in JOSS. Thanks to the authors for their rapid and helpful communications during the review process. I checked off the version checkbox, but given the tweaks that happened during review, there should probably be a new minor version released (e.g. v1.1.0) that will correspond to its accepted state. |
@jschwab , thank you for your prompt and thorough review! @kyleniemeyer , do you agree with this assessment? |
@dwillcox @zingale a few minor comments:
|
Otherwise, this looks good! |
Oh, one other comment: it might be helpful to have a link from the docs page back to the repository; I couldn't find one. |
I've added a link to the project github on the docs index page. I also added install instructions (and fixed an issue in the I'll work on the references. |
@whedon generate pdf |
|
okay, I think all the DOIs that are available are in place now. |
@zingale The install instructions in pynucastro/pynucastro@27bb810 trail off. "This will put the..." |
indeed they do! a little to quick on the push. |
OK, looks good to me! |
Hi @katyhuff @jschwab @kyleniemeyer, Thank you for all your helpful review suggestions that have significantly improved the usability and accessibility of pynucastro. Today I pushed a commit adding a brief section to the documentation describing a previously undocumented feature of pynucastro: Specifying Desired Nuclei to Construct a Network I have just tagged two commits as follows on github:
We are ready for whatever the next steps are, please let us know. Thanks again! |
Just looked that bit over. That's a nice feature. |
Thanks, I'm glad to hear it! |
Wonderful! Thanks @dwillcox @zingale @jschwab & @kyleniemeyer ! @dwillcox & @zingale : Could you make an archive of the current version of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission. |
Hi @katyhuff I have archived the current version on Zenodo, here is the DOI: 10.5281/zenodo.1202434 |
Also, I had to make a new release on github in order for Zenodo to archive it, so this is v1.1.1. |
@whedon set 10.5281/zenodo.1202434 as archive |
OK. 10.5281/zenodo.1202434 is the archive. |
@whedon generate pdf |
|
@arfon we're ready to accept this! |
@jschwab @kyleniemeyer - many thanks for your reviews here and to @katyhuff for editing this submission ✨ @dwillcox - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00588 ⚡️:rocket: :boom: |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippet:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thanks again @katyhuff @jschwab @kyleniemeyer -- it's been a pleasure interacting with you as we prepared pynucastro for publication via JOSS. This was my first time using JOSS and this has been a very constructive experience! -Don |
Quick question @katyhuff -- since we retain copyright to the JOSS paper and it's licensed as CC-BY, can we submit the JOSS paper to the arXiv preprint server without modification? |
Whoops --- I only just now saw this. Yes, I think so. |
Submitting author: @dwillcox (Donald Willcox)
Repository: https://github.com/pynucastro/pynucastro
Version: 1.1.1
Editor: @katyhuff
Reviewer: @jschwab
Archive: 10.5281/zenodo.1202434
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@kyleniemeyer, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @katyhuff know.
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: