[REVIEW]: concstats: Market Structure, Concentration and Inequality Measures, with R

[editorialbot]

Submitting author: @schneiderpy (Andreas Schneider)
Repository: https://github.com/ropensci/concstats
Branch with paper.md (empty if default branch):
Version: v.0.1.6
Editor: @arfon
Reviewers: @SebastianWojcik86, @christopherkenny
Archive: 10.5281/zenodo.7803764

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bca9a2ab9727d790c96b3229c384f5b0"><img src="https://joss.theoj.org/papers/bca9a2ab9727d790c96b3229c384f5b0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bca9a2ab9727d790c96b3229c384f5b0/status.svg)](https://joss.theoj.org/papers/bca9a2ab9727d790c96b3229c384f5b0)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@SebastianWojcik86 & @christopherkenny, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@SebastianWojcik86, please create your checklist typing: @editorialbot generate my checklist

@christopherkenny, please create your checklist typing: @editorialbot generate my checklist

[editorialbot]

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (1117.2 files/s, 190645.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            34            952            141           4214
R                               12            319           1126           1760
Markdown                         7            339              0           1171
CSS                              3             98             52            442
JavaScript                       3             64             32            256
YAML                             6             34             11            181
JSON                             1              0              0            170
TeX                              1             13              0            136
XML                              1              0              0            105
Rmd                              3            107            454             97
SVG                              1              0              1             11
-------------------------------------------------------------------------------
SUM:                            72           1926           1817           8543
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 1735

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1515/zfgg-2022-0002 is OK
- 10.1016/j.jebo.2008.03.010 is OK
- 10.1002/j.1538-7305.1948.tb01338.x is OK
- 10.18356/395c7874-en is OK
- 10.3846/1611-1699.2009.10.191-198 is OK
- 10.21105/joss.00828 is OK

MISSING DOIs

- 10.1504/ijaf.2009.029147 may be a valid DOI for title: Banking concentration and the price-concentration relationship: the case of Brazil

INVALID DOIs

- None

[arfon]

@SebastianWojcik86, @christopherkenny – just to confirm., there's nothing for you to do here as you've already completed the rOpenSci review 😸

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[arfon]

@schneiderpy, could you please merge this PR? ropensci/concstats#2

Also, please check the possible missing DOI (10.1504/ijaf.2009.029147 may be a valid DOI for title: Banking concentration and the price-concentration relationship: the case of Brazil) and update your BibTeX file accordingly.

[schneiderpy]

@arfon, thank you for you message. I have fixed the mentioned DOI and updated the bib. file accordingly. Furthermore, I have added the JOSS badge (Under review). Thank you.

[arfon]

@editorialbot recommend-accept

[editorialbot]

Paper is not ready for acceptance yet, the archive is missing

[arfon]

@editorialbot set 10.5281/zenodo.7803764 as archive

[editorialbot]

Done! archive is now 10.5281/zenodo.7803764

[arfon]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1515/zfgg-2022-0002 is OK
- 10.1016/j.jebo.2008.03.010 is OK
- 10.1002/j.1538-7305.1948.tb01338.x is OK
- 10.18356/395c7874-en is OK
- 10.3846/1611-1699.2009.10.191-198 is OK
- 10.21105/joss.00828 is OK

MISSING DOIs

- 10.1504/ijaf.2009.029147 may be a valid DOI for title: Banking concentration and the price-concentration relationship: the case of Brazil

INVALID DOIs

- None

[editorialbot]

⚠️ Error preparing paper acceptance. The generated XML metadata file is invalid.

IDREFS attribute rid references an unknown ID "figU003Amstruct"

[arfon]

@schneiderpy – looks like the \ref{fig:mstruct}) is throwing an error here. I think it might be the : in the label? Please check these docs and see if you can figure it out: https://joss.readthedocs.io/en/latest/submitting.html#internal-references

[schneiderpy]

@arfon - to understand the error .. the error ocurrs when generating the paper? (however, generating the draft worked fine)

[schneiderpy]

@arfon - Error is fixed. Thank you

[arfon]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1515/zfgg-2022-0002 is OK
- 10.1016/j.jebo.2008.03.010 is OK
- 10.1002/j.1538-7305.1948.tb01338.x is OK
- 10.18356/395c7874-en is OK
- 10.3846/1611-1699.2009.10.191-198 is OK
- 10.21105/joss.00828 is OK

MISSING DOIs

- 10.1504/ijaf.2009.029147 may be a valid DOI for title: Banking concentration and the price-concentration relationship: the case of Brazil

INVALID DOIs

- None

[editorialbot]

👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4628, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[arfon]

@editorialbot accept

[editorialbot]

Doing it live! Attempting automated processing of paper acceptance...

[editorialbot]

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Schneider
  given-names: Andreas
  orcid: "https://orcid.org/0000-0001-5630-1097"
doi: 10.5281/zenodo.7803764
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Schneider
    given-names: Andreas
    orcid: "https://orcid.org/0000-0001-5630-1097"
  date-published: 2023-09-29
  doi: 10.21105/joss.05885
  issn: 2475-9066
  issue: 89
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 5885
  title: "concstats: Market Structure, Concentration and Inequality
    Measures, with R"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.05885"
  volume: 8
title: "concstats: Market Structure, Concentration and Inequality
  Measures, with R"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

[editorialbot]

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

[editorialbot]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.05885 joss-papers#4630
1. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05885
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

[arfon]

@SebastianWojcik86, @christopherkenny – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@schneiderpy – your paper is now accepted and published in JOSS ⚡🚀💥

[editorialbot]

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05885/status.svg)](https://doi.org/10.21105/joss.05885)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05885">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05885/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05885/status.svg
   :target: https://doi.org/10.21105/joss.05885

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
• Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss