Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AutoEIS: An automated tool for analysis of electrochemical impedance spectroscopy using evolutionary algorithms and Bayesian inference #6161

Closed
editorialbot opened this issue Dec 19, 2023 · 27 comments
Assignees
Labels
pre-review Python Shell TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Dec 19, 2023

Submitting author: @ma-sadeghi (Mohammad Amin Sadeghi)
Repository: https://github.com/AUTODIAL/AutoEIS/
Branch with paper.md (empty if default branch): joss
Version: v0.0.18
Editor: @lucydot
Reviewers: @dap-biospec, @DevT-0
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a073ad3ce9719adc3cce19fb586414e4"><img src="https://joss.theoj.org/papers/a073ad3ce9719adc3cce19fb586414e4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a073ad3ce9719adc3cce19fb586414e4/status.svg)](https://joss.theoj.org/papers/a073ad3ce9719adc3cce19fb586414e4)

Author instructions

Thanks for submitting your paper to JOSS @ma-sadeghi. Currently, there isn't a JOSS editor assigned to your paper.

@ma-sadeghi if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Dec 19, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.07 s (320.9 files/s, 117200.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          12            515            734           1694
Jupyter Notebook                 2              0           3456           1645
Bourne Shell                     2             20             12            151
Markdown                         2             49              0            124
TeX                              1              0              0            118
YAML                             3              8             11            102
TOML                             1              4              0             55
Dockerfile                       1             14              8             46
-------------------------------------------------------------------------------
SUM:                            24            610           4221           3935
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 989

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.02349 is OK
- 10.5281/zenodo.2535951 is OK
- 10.1016/j.electacta.2020.136864 is OK
- 10.1149/1.2044210 is OK
- 10.1149/1945-7111/aceab2 is OK

MISSING DOIs

- 10.1109/tim.2021.3113116 may be a valid DOI for title: Practical equivalent electrical circuit identification for electrochemical impedance spectroscopy analysis with gene expression programming

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

impedance.py: A Python package for electrochemical impedance analysis
Submitting author: @mdmurbach
Handling editor: @mbobra (Active)
Reviewers: @ma-sadeghi, @EricaEgg
Similarity score: 0.8637

Easy SimAuto (ESA): A Python Package that Simplifies Interacting with PowerWorld Simulator
Submitting author: @blthayer
Handling editor: @danielskatz (Active)
Reviewers: @robinroche, @tonyelhabr
Similarity score: 0.8224

PyEI: A Python package for ecological inference
Submitting author: @karink520
Handling editor: @drvinceknight (Active)
Reviewers: @matt-graham, @pmyteh
Similarity score: 0.8215

GIMS: Graphical Interface for Materials Simulations
Submitting author: @kokookster
Handling editor: @jgostick (Active)
Reviewers: @marshallmcdonnell, @jgostick
Similarity score: 0.8210

KinESim: Pre-equilibrium kinetic simulation of electrochemical reactions
Submitting author: @dap-biospec
Handling editor: @kyleniemeyer (Active)
Reviewers: @usethedata, @faustincarter
Similarity score: 0.8204

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @lucydot as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@lucydot
Copy link

lucydot commented Dec 19, 2023

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @lucydot is now the editor

@ma-sadeghi
Copy link

ma-sadeghi commented Dec 19, 2023

The missing DOI is now fixed. Also, just merged a massive refactor of the package (AUTODIAL/AutoEIS/pull/58), plus a new release (v0.0.18) issued to PyPI.

Update: Another major PR on improving the documentation was just merged (AUTODIAL/AutoEIS#62).

@lucydot
Copy link

lucydot commented Dec 21, 2023

Hello @ma-sadeghi, a quick comment to say I am on leave for the next two weeks. I'll be straight on this once I am back at work in the new year - one reviewer is already secured and I will add them once I receive their github username.

Best,

Lucy

@ma-sadeghi
Copy link

@lucydot Thanks for the update, looking forward to it. Happy new year!

@lucydot
Copy link

lucydot commented Jan 8, 2024

@editorialbot set v0.0.18 as version

@editorialbot
Copy link
Collaborator Author

Done! version is now v0.0.18

@lucydot
Copy link

lucydot commented Jan 8, 2024

@mdmurbach, @dap-biospec - are you available to review this submission to JOSS?

@lucydot
Copy link

lucydot commented Jan 9, 2024

@DevT-0 - can you review this submission?

@DevT-0
Copy link

DevT-0 commented Jan 15, 2024

Thanks for the invite, Lucy. Yes, I will be happy to review this submission.

@dap-biospec
Copy link

I can review this submission. Thank you for the invitation!

@lucydot
Copy link

lucydot commented Jan 22, 2024

Excellent!

@lucydot
Copy link

lucydot commented Jan 22, 2024

@editorialbot add @dap-biospec as reviewer

@editorialbot
Copy link
Collaborator Author

@dap-biospec added to the reviewers list!

@lucydot
Copy link

lucydot commented Jan 22, 2024

@editorialbot add @DevT-0 as reviewer

@editorialbot
Copy link
Collaborator Author

@DevT-0 added to the reviewers list!

@lucydot
Copy link

lucydot commented Jan 22, 2024

@DevT-0 @dap-biospec thank-you for agreeing to review this submission.

I'm going to ask editorial bot to start the review - you will receive a github notification from the new review issue thread. At the top of that thread are reviewer instructions: if you have any other questions, it is best to ask me over in the new thread.

@lucydot
Copy link

lucydot commented Jan 22, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6256.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python Shell TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

6 participants