Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: mmappickle: A Python 3 library to store memory mappable objects into pickle-compatible files #618

Closed
whedon opened this issue Mar 13, 2018 · 23 comments
Assignees

Comments

@whedon
Copy link

whedon commented Mar 13, 2018

Submitting author: @lfasnacht (Laurent Fasnacht)
Repository: https://github.com/UniNE-CHYN/mmappickle
Version: v1.0.0
Editor: @arfon
Reviewers: @glemaitre, @clemaitre58

Author instructions

Thanks for submitting your paper to JOSS @lfasnacht. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@lfasnacht if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Mar 13, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented Mar 13, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon whedon added the Python label Mar 13, 2018
@whedon
Copy link
Author

whedon commented Mar 13, 2018

@lfasnacht
Copy link

There seem to be an issue with the bullet list in the article proof, does somebody know how can I fix that?

@arfon
Copy link
Member

arfon commented Mar 15, 2018

@lfasnacht - this should fix it: UniNE-CHYN/mmappickle#2

The Pandoc converter is a little more fussy than GitHub about markdown structure.

@lfasnacht
Copy link

Merged, thank you very much!

@lfasnacht
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 15, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Mar 15, 2018

@arfon
Copy link
Member

arfon commented Mar 26, 2018

@stensy, @clemaitre58, @glemaitre - would you be willing to review this submission for JOSS? I'd like to find a couple of reviewers for this submission.

@glemaitre
Copy link

I can be one of the reviewer.

@clemaitre58
Copy link

@arfon I could also one of them

@arfon
Copy link
Member

arfon commented Mar 27, 2018

@whedon assign @glemaitre as reviewer

@arfon
Copy link
Member

arfon commented Mar 27, 2018

@whedon add @clemaitre58 as reviewer

@arfon
Copy link
Member

arfon commented Mar 27, 2018

@whedon assign @arfon as editor

@whedon
Copy link
Author

whedon commented Mar 27, 2018

OK, the editor is @arfon

@arfon
Copy link
Member

arfon commented Mar 27, 2018

@whedon assign @glemaitre as reviewer

@whedon
Copy link
Author

whedon commented Mar 27, 2018

OK, the reviewer is @glemaitre

@whedon whedon assigned arfon and unassigned arfon Mar 27, 2018
@arfon
Copy link
Member

arfon commented Mar 27, 2018

@whedon add @clemaitre58 as reviewer

@whedon
Copy link
Author

whedon commented Mar 27, 2018

OK, @clemaitre58 is now a reviewer

@arfon
Copy link
Member

arfon commented Mar 27, 2018

@whedon start review magic-word=bananas

@arfon arfon closed this as completed Mar 27, 2018
@whedon
Copy link
Author

whedon commented Mar 27, 2018

OK, I've started the review over in #651. Feel free to close this issue now!

@arfon
Copy link
Member

arfon commented Mar 27, 2018

@glemaitre, @clemaitre58 - thanks for agreeing to review this. Please head over to #651 for the actual review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants