Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PythonicDISORT: A Python reimplementation of the Discrete Ordinate Radiative Transfer package DISORT #6399

Closed
editorialbot opened this issue Feb 23, 2024 · 26 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 23, 2024

Submitting author: @dhjx1996 (Jia Xu Dion Ho)
Repository: https://github.com/LDEO-CREW/Pythonic-DISORT
Branch with paper.md (empty if default branch):
Version: v0.4.2
Editor: @phibeck
Reviewers: @arjunsavel, @simonrp84, @pscicluna
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ec19f2796dac7303ea3bd476455b641f"><img src="https://joss.theoj.org/papers/ec19f2796dac7303ea3bd476455b641f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ec19f2796dac7303ea3bd476455b641f/status.svg)](https://joss.theoj.org/papers/ec19f2796dac7303ea3bd476455b641f)

Author instructions

Thanks for submitting your paper to JOSS @dhjx1996. Currently, there isn't a JOSS editor assigned to your paper.

@dhjx1996 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Feb 23, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.95 s (67.4 files/s, 46556.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Fortran 77                       8           2738           8727           8640
Jupyter Notebook                24              0          11827           5269
Python                          14            517            657           2423
Fortran 90                       1            508            128           2043
Markdown                         5             76              0            287
YAML                             4             12             22            117
TeX                              1              5              0             73
TOML                             1              3              0             31
DOS Batch                        1              8              1             26
reStructuredText                 2             11             18             13
make                             2              7              8             12
Bourne Shell                     1              1              6              6
-------------------------------------------------------------------------------
SUM:                            64           3886          21394          18940
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 873

@editorialbot
Copy link
Collaborator Author

@dhjx1996
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@dhjx1996
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @dhjx1996, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@dhjx1996
Copy link

Suggested reviewers: arjunsavel, Peter Scicluna, simonrp84 because Radiative Transfer is in their topic area.

@phibeck
Copy link

phibeck commented Mar 4, 2024

Hi @kyleniemeyer I can take this one

@phibeck
Copy link

phibeck commented Mar 4, 2024

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @phibeck is now the editor

@phibeck
Copy link

phibeck commented Mar 4, 2024

@dhjx1996 thanks for the suggestions! I'll be looking for reviewers next.

@phibeck
Copy link

phibeck commented Mar 4, 2024

👋 @arjunsavel, @pscicluna & @simonrp84, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@arjunsavel
Copy link

@phibeck happy to review this!

@simonrp84
Copy link

@phibeck In principle yes I'd be happy to review, but I'm travelling a lot for work in the next 2 weeks so I hope it'd be OK if I get a review done in late March...

@pscicluna
Copy link

@phibeck Looks like I'm a little late to the party - similarly, I could do it in principle, but my time is quite limited in the near future.

@phibeck
Copy link

phibeck commented Mar 4, 2024

@pscicluna not at all late - more reviewers are always welcome! @arjunsavel and @simonrp84, thank you all for agreeing to review! And thank you for letting me know your time constraints, that's not a problem.

@phibeck
Copy link

phibeck commented Mar 4, 2024

@editorialbot add @arjunsavel as reviewer

@editorialbot
Copy link
Collaborator Author

@arjunsavel added to the reviewers list!

@phibeck
Copy link

phibeck commented Mar 4, 2024

@editorialbot add @simonrp84 as reviewer

@editorialbot
Copy link
Collaborator Author

@simonrp84 added to the reviewers list!

@phibeck
Copy link

phibeck commented Mar 4, 2024

@editorialbot add @pscicluna as reviewer

@editorialbot
Copy link
Collaborator Author

@pscicluna added to the reviewers list!

@phibeck
Copy link

phibeck commented Mar 4, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants