Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PourPy - A python package to generate potential-pH diagrams #6446

Closed
editorialbot opened this issue Mar 6, 2024 · 19 comments
Closed
Assignees
Labels
pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 6, 2024

Submitting author: @mohitpundir (Mohit Pundir)
Repository: https://gitlab.com/cmbm-ethz/pourbaix-diagrams
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @rkurchin
Reviewers: @yaomz16, @sudarshanv01
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/70f75ac2c37f013f8edaa35774759183"><img src="https://joss.theoj.org/papers/70f75ac2c37f013f8edaa35774759183/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/70f75ac2c37f013f8edaa35774759183/status.svg)](https://joss.theoj.org/papers/70f75ac2c37f013f8edaa35774759183)

Author instructions

Thanks for submitting your paper to JOSS @mohitpundir. Currently, there isn't a JOSS editor assigned to your paper.

@mohitpundir if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Mar 6, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (974.4 files/s, 256211.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              1              1              1           4248
Python                          19            456            525           1489
Jupyter Notebook                10              0           2798            568
Markdown                         2             32              0            116
TeX                              1              9              0             61
TOML                             1             12              1             33
DOS Batch                        1              8              1             26
reStructuredText                 3             21             26             15
YAML                             1             25             16             10
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            40            568           3375           6575
-------------------------------------------------------------------------------

Commit count by author:

    70	Mohit Pundir
    49	Furcas  Fabio
     9	Anja Korber
     4	Mohit pundir
     3	Fabio

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1462

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

@rkurchin
Copy link

rkurchin commented Mar 6, 2024

@editorialbot assign me as editor

🤚 I can take this one!

@editorialbot
Copy link
Collaborator Author

Assigned! @rkurchin is now the editor

@rkurchin
Copy link

rkurchin commented Mar 6, 2024

👋 @mdmurbach and/or @mwerwee, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@rkurchin
Copy link

@editorialbot add @yaomz16 as reviewer

(invited outside of GitHub through a personal connection)

@editorialbot
Copy link
Collaborator Author

@yaomz16 added to the reviewers list!

@rkurchin
Copy link

👋 @lscalfi and/or @sudarshanv01, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@sudarshanv01
Copy link

Sorry about the late reply, I would be happy to!

@lscalfi
Copy link

lscalfi commented Mar 25, 2024

Hi, sorry but I won't have enough time for this review

@rkurchin
Copy link

@editorialbot @sudarshanv01 as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@rkurchin
Copy link

@editorialbot add @sudarshanv01 as reviewer

@editorialbot
Copy link
Collaborator Author

@sudarshanv01 added to the reviewers list!

@rkurchin
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6536.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

4 participants