Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ADIOS4DOLFINx: A framework for checkpointing in FEniCS #6449

Closed
editorialbot opened this issue Mar 6, 2024 · 33 comments
Closed
Assignees
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 6, 2024

Submitting author: @jorgensd (Jørgen Schartum Dokken)
Repository: https://github.com/jorgensd/adios4dolfinx
Branch with paper.md (empty if default branch):
Version: v0.8.0
Editor: @danielskatz
Reviewers: @gonsie, @Chilipp
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7866cb142db8a803e32d79a109573d25"><img src="https://joss.theoj.org/papers/7866cb142db8a803e32d79a109573d25/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7866cb142db8a803e32d79a109573d25/status.svg)](https://joss.theoj.org/papers/7866cb142db8a803e32d79a109573d25)

Author instructions

Thanks for submitting your paper to JOSS @jorgensd. Currently, there isn't a JOSS editor assigned to your paper.

@jorgensd if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Mar 6, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.10447666 is OK
- 10.1016/j.softx.2020.100561 is OK
- 10.48550/arXiv.2401.05868 is OK
- 10.1145/2998441 is OK
- 10.1145/3524456 is OK

MISSING DOIs

- No DOI given, and none found for title: XDMF and ParaView: checkpointing format
- No DOI given, and none found for title: MPI: A Message-Passing Interface Standard. Version...

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (1123.7 files/s, 143945.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          31            947            749           3881
YAML                            12             97             22            379
Markdown                         5             87              0            220
TeX                              1              9              0             69
TOML                             1              9              5             54
reStructuredText                 1              1              2              2
-------------------------------------------------------------------------------
SUM:                            51           1150            778           4605
-------------------------------------------------------------------------------

Commit count by author:

    44	Jørgen S. Dokken
    43	Jørgen Schartum Dokken
    29	Jorgen S. Dokken
    12	Henrik Finsberg
     5	Francesco Ballarin
     3	jorgensd
     1	Joergen Schartum Dokken
     1	Nate

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 942

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jorgensd
Copy link

jorgensd commented Mar 6, 2024

@editorialbot generate pdf

@danielskatz
Copy link

👋 @jorgensd - thanks for your submission. I'll be editing it.

If you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission. You can also suggest people not on the JOSS list.

@danielskatz
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @danielskatz is now the editor

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jorgensd
Copy link

jorgensd commented Mar 6, 2024

👋 @jorgensd - thanks for your submission. I'll be editing it.

If you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission. You can also suggest people not on the JOSS list.

I guess lukeolson might be appropriate.
I've previously worked (and lived with) mscroggs and IgorBaratta, and have co-authored several papers with them, so I guess that excludes them.

@danielskatz
Copy link

Yes, folks that you have a conflict of interest with can't review. Note that our COI rule goes back 4 years on previous collaborations, so if something is older than that, it's ok.

A few more suggestions would be welcome.

@danielskatz
Copy link

👋 @lukeolson - would you be willing to review this submission for JOSS?

@jorgensd
Copy link

jorgensd commented Mar 7, 2024

Yes, folks that you have a conflict of interest with can't review. Note that our COI rule goes back 4 years on previous collaborations, so if something is older than that, it's ok.

A few more suggestions would be welcome.

What about https://github.com/mikaem? He was a lecturer during my master studies, But that is almost a decade ago.

Or: https://github.com/gonsie or: https://github.com/Chilipp

@danielskatz
Copy link

👋 @mikemahoney218, @gonsie, @Chilipp - would one or two of you be willing to review this JOSS submission?

@jorgensd
Copy link

jorgensd commented Mar 7, 2024

👋 @mikemahoney218, @gonsie, @Chilipp - would one or two of you be willing to review this JOSS submission?

Did you mean tagging mikemahoney218 or did you mean mikaem?:)

@danielskatz
Copy link

sorry, autocomplete...

@danielskatz
Copy link

👋 @mikaem - would you be willing to review this submission for JOSS?

@jorgensd
Copy link

jorgensd commented Mar 7, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@gonsie
Copy link

gonsie commented Mar 7, 2024

Count me in!

@Chilipp
Copy link

Chilipp commented Mar 7, 2024

I must admit that I have not yet heard about Dolphin, but I do have some experience in parallelization. If you think that is enough for being a reviewer @jorgensd, I am happy to serve as a reviewer here!

@jorgensd
Copy link

jorgensd commented Mar 7, 2024

I must admit that I have not yet heard about Dolphin, but I do have some experience in parallelization. If you think that is enough for being a reviewer @jorgensd, I am happy to serve as a reviewer here!

The software is a MPI based framework for storing checkpoints (function or mesh data) from simulations from FEniCS, that is a software for solving PDEs with finite elements, and making it compatible across runs with different number of processes.

Most of the actual source code is pure numpy (vectorized) and using MPI neighborhood communicators to transfer these arrays to and from processes, along with using ADIOS2.

I have no issue with you being a reviewer.

@danielskatz
Copy link

FYI, the author doesn't actually choose or accept reviewers; this is the role of the editor

But discussion about reviewer suitability is great to have - thanks!

@danielskatz
Copy link

@gonsie and @Chilipp - I'm going to go ahead and add both of you and start the review. Thanks very much for agreeing so quickly!

@danielskatz
Copy link

@editorialbot add @gonsie as reviewer

@editorialbot
Copy link
Collaborator Author

@gonsie added to the reviewers list!

@danielskatz
Copy link

@editorialbot add @Chilipp as reviewer

@editorialbot
Copy link
Collaborator Author

@Chilipp added to the reviewers list!

@danielskatz
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6451.

@jorgensd
Copy link

jorgensd commented Mar 7, 2024

FYI, the author doesn't actually choose or accept reviewers; this is the role of the editor

But discussion about reviewer suitability is great to have - thanks!

I know. Just saying ive got no issues, or conflicts of interest:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

5 participants