Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: GALAssify: A Python package for visually classifying astronomical objects #6597

Closed
editorialbot opened this issue Apr 9, 2024 · 13 comments
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @Manalclay (Manuel Luis Alcázar Laynez)
Repository: https://gitlab.com/astrogal/GALAssify
Branch with paper.md (empty if default branch):
Version: v1.0.1
Editor: Pending
Reviewers: Pending
Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7550f27b9b185e6daa40f42e3fc07d1c"><img src="https://joss.theoj.org/papers/7550f27b9b185e6daa40f42e3fc07d1c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7550f27b9b185e6daa40f42e3fc07d1c/status.svg)](https://joss.theoj.org/papers/7550f27b9b185e6daa40f42e3fc07d1c)

Author instructions

Thanks for submitting your paper to JOSS @Manalclay. Currently, there isn't a JOSS editor assigned to your paper.

@Manalclay if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Apr 9, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (691.1 files/s, 114382.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           5            300            261           1064
TeX                              4            106            140            709
Markdown                         2             70              0            238
Qt                               1              0              0            225
CSV                              7              0              0            105
TOML                             1              9              0             83
-------------------------------------------------------------------------------
SUM:                            20            485            401           2424
-------------------------------------------------------------------------------

Commit count by author:

     2	mrmanlu

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1318

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1051/0004-6361/201322068 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1088/1538-3873/aa5785 is OK
- 10.1051/0004-6361/201526016 is OK
- 10.1051/0004-6361/202141888 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1086/301513 is OK

MISSING DOIs

- No DOI given, and none found for title: LSSGALPY: Visualization of the large-scale environ...
- 10.1109/mcse.2007.55 may be a valid DOI for title: Matplotlib: A 2D graphics environment
- 10.25080/majora-92bf1922-00a may be a valid DOI for title:  Data Structures for Statistical Computing in Pyth...

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@dfm
Copy link

dfm commented Apr 9, 2024

@editorialbot query scope

@Manalclay — Thanks for your submission! Given the small size and short history of this code base, I have submitted this pre-review for editorial review with respect to the substantial scholarly effort criterion. This usually takes a week or two and I'll report back here as soon as I hear back from the rest of the editorial board.

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Apr 9, 2024
@Manalclay
Copy link

Hello @dfm! Thank you for send it for review.

Actually, we have been working in the repository that our university bring us: https://gloton.ugr.es/gitlab/lss/galassify
However, the university repository did not allow guest to posting issues without login, which was a requisite for publishing.
Thus, we opted to publishing the official releases to this new repository, hosted in gitlab and not in the university server.

We hope this will not be an inconvenience. Please feel free to advise us on any aspect that may be of interest to us.

@dfm
Copy link

dfm commented May 8, 2024

@editorialbot reject

@Manalclay — Thanks for your patience with our review. Unfortunately the editorial team has decided that this submission does not reach the "substantial scholarly effort" threshold for consideration by JOSS. I note that this is not a judgement on the quality of the work! Other options for publishing open source scientific software are listed in our docs here: https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages

@editorialbot
Copy link
Collaborator Author

Paper rejected.

@Manalclay
Copy link

Dear @dfm,

Taking into account the reason of the rejection, we currently moved our project completely to the repository, including open and closed issues, commits and branches.

Consequently, we wonder if it would be possible for you to consider evaluating our work a second time taking into account all the work done.

Thank you in advance. Regards,
Manuel

@dfm
Copy link

dfm commented May 10, 2024

@Manalclay — We would be open to re-submission at a future date, once this project has reached a more mature state. It seems unlikely to me that the code in the same state would warrant a different result from the scope query just by migrating issues and branches. It could help to add testing infrastructure, and a clearer argument for how this project would be reusable for other research projects. But, ultimately, such a small code base for a GUI project is unlikely to be within scope for JOSS until it is mature and clearly widely usable. Thanks for your understanding, and I hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

3 participants