Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: DiffeRT2d: A Differentiable Ray Tracing Python Framework for Radio Propagation #6908

Closed
editorialbot opened this issue Jun 20, 2024 · 23 comments
Assignees
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jun 20, 2024

Submitting author: @jeertmans (Jérome Eertmans)
Repository: https://github.com/jeertmans/DiffeRT2d
Branch with paper.md (empty if default branch):
Version: v0.3.2
Editor: @danielskatz
Reviewers: @idoby, @roth-jakob
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/5a48c7901e2d9de3d9e13dc0e39615a0"><img src="https://joss.theoj.org/papers/5a48c7901e2d9de3d9e13dc0e39615a0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/5a48c7901e2d9de3d9e13dc0e39615a0/status.svg)](https://joss.theoj.org/papers/5a48c7901e2d9de3d9e13dc0e39615a0)

Author instructions

Thanks for submitting your paper to JOSS @jeertmans. Currently, there isn't a JOSS editor assigned to your paper.

@jeertmans if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Jun 20, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.23919/EuCAP60739.2024.10501570 is OK
- 10.1109/TAP.2014.2323961 is OK
- 10.1109/ACCESS.2015.2453991 is OK
- 10.23919/EuCAP57121.2023.10132934 is OK
- 10.1371/journal.pone.0260060 is OK

MISSING DOIs

- No DOI given, and none found for title: Adam: A Method for Stochastic Optimization
- No DOI given, and none found for title: The DeepMind JAX Ecosystem
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: jaxtyping: type annotations and runtime checking f...
- No DOI given, and none found for title: Equinox: neural networks in JAX via callable PyTre...
- No DOI given, and none found for title: Advanced Radio Channel Simulator
- 10.1109/gcwkshps58843.2023.10465179 may be a valid DOI for title: Sionna RT: Differentiable Ray Tracing for Radio Pr...
- No DOI given, and none found for title: TensorFlow: Large-Scale Machine Learning on Hetero...

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.06 s (1166.8 files/s, 185241.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          31           1346           1631           4323
Markdown                        18            443              0           1197
Jupyter Notebook                 1              0           1341            572
YAML                             8             43             10            256
TeX                              2             18              0            185
TOML                             1             23              5            170
JSON                             1              0              0            154
SVG                              1              0              0             54
DOS Batch                        1              8              1             26
reStructuredText                 9             11             33             20
make                             1              6              7             14
CSS                              1              1              0              9
-------------------------------------------------------------------------------
SUM:                            75           1899           3028           6980
-------------------------------------------------------------------------------

Commit count by author:

   277	Jérome Eertmans
    36	pre-commit-ci[bot]
     9	dependabot[bot]
     2	ImgBotApp

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1243

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@idoby
Copy link

idoby commented Jun 21, 2024

@danielskatz Hey, this came up in my GitHub feed and seems cool. I'd like to be a reviewer if possible.

@danielskatz
Copy link

👋 @idoby - thanks - I'll go ahead and assign you, and I'll also assign myself as editor, then look for at least one more reviewer.

@danielskatz
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @danielskatz is now the editor

@danielskatz
Copy link

@editorialbot add @idoby as reviewer

@editorialbot
Copy link
Collaborator Author

@idoby added to the reviewers list!

@danielskatz
Copy link

👋 @jeertmans - thanks for your submission.

Can you please suggest a few potential reviewers, optionally from the list of people that have already agreed to review. If you know a potential reviewer's GitHub username, then please mention it here in this thread (without tagging it with an @).

@jeertmans
Copy link

jeertmans commented Jun 21, 2024

Hello @danielskatz, sure!
According to this list, I think the following users might be relevant reviewers:

  • LyceanEM
  • klb2
  • thippesha-d

@danielskatz
Copy link

👋 @LyceanEM - Would you be willing to review this JOSS submission?

@danielskatz
Copy link

👋 @klb2 - Would you be willing to review this JOSS submission?

@danielskatz
Copy link

👋 @roth-jakob, @hawkinsp, and @wsmoses - Given the JAX commonality here with the paper we just finished, I wonder if any of you would be interested in reviewing this submission?

@roth-jakob
Copy link

I would be happy to review!

@danielskatz
Copy link

Thanks @roth-jakob - I'll add you to the reviewer list, and I think we'll go ahead and start this with two reviewers

@danielskatz
Copy link

@editorialbot add @roth-jakob as reviewer

@editorialbot
Copy link
Collaborator Author

@roth-jakob added to the reviewers list!

@danielskatz
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6915.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

5 participants