New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: ungroup: An R package for efficient estimation of smooth distributions from coarsely binned data #937
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @rlbarter it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
Thank you @rlbarter for agreeing to review the |
Just a few minor revision comments:
|
@rlbarter Good to check the latest version. The bump from |
@rlbarter Thanks for your comments. See below my response.
The last point I will address in the next comment. |
Consider the following problem: Based on the info above we can not calculate the average age unless we know the age of every student. However, we can approximate it by building a histogram with 2 bars ( Now, if we would be able somehow to build a histogram with more bars, say 6 bars ( For more real-world example and explanation of the method see this article: https://academic.oup.com/aje/article/182/2/138/94562 Regarding the two examples, the difference is seen in the estimated groups and estimated counts: > # Example 1 ----------------------
> M1 <- pclm(x, y, nlast)
> head(fitted(M1))
[0,1) [1,2) [2,3) [3,4) [4,5) [5,6)
292.254945 47.567040 12.031104 5.101512 3.653694 3.801854
> # Example 2 ----------------------
> # ungroup even in smaller intervals
> M2 <- pclm(x, y, nlast, out.step = 0.5)
> head(fitted(M2))
[0,0.5) [0.5,1) [1,1.5) [1.5,2) [2,2.5) [2.5,3)
211.751314 80.583505 32.679931 14.663353 7.463173 4.379769 Note, in example 1 we are estimating intervals of length 1. In example 2 we are estimating intervals of length 0.5 using the same aggregate data. Visually the difference can be seen like this: > plot(M1, type = "s")
> plot(M2, type = "s") |
@rlbarter Your suggestions have been addressed in |
@mpascariu Great. This all looks good to me! Up to you whether you want to add a URL link to the vignette in the README (I personally find this helpful in general when I go to R packages on GitHub). |
@rlbarter Excellent. Thank you very much. |
@whedon generate pdf |
|
@mpascariu Before I accept, can you please archive this version of the software on Zenodo and post a a DOI for me please? |
@karthik The Zenodo doi is: 10.5281/zenodo.1421648 As discussed with @arfon in Thanks. |
@mpascariu As @arfon noted earlier, it is very challenging to typeset accurately when using markdown + pandoc. Given that you also have such a short paper the accurate placement you seek would be very challenging (without inserting a lot of empty space and page breaks). You might have to mess with figure sizes to make it fit the way you seek. I'll let @arfon weigh in but I think the paper looks fine the way it is. |
@karthik I understand. I made some minor changes in the |
@whedon generate pdf |
|
@mpascariu - you can ask @whedon to recompile the paper for you with Also, it looks like the |
@arfon It is corrected now. |
@whedon generate pdf |
|
@arfon I think the article looks fine now. Thank you very much. |
@whedon set 10.5281/zenodo.1421648 as archive |
OK. 10.5281/zenodo.1421648 is the archive. |
@mpascariu Thank you for the submission! And thanks @rlbarter for the review! This is ready to accept @arfon 🎉 |
Thank you everyone for your work! It is much appreciated. |
@rlbarter - many thanks for your review here and to @karthik for editing this submission ✨ @mpascariu - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00937 ⚡ 🚀 💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @mpascariu (Marius Dan Pascariu)
Repository: https://github.com/mpascariu/ungroup
Version: v1.0.3
Editor: @karthik
Reviewer: @rlbarter
Archive: 10.5281/zenodo.1421648
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@rlbarter, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @karthik know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @rlbarter
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: