Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution process for JOSS code and policies #1335

Open
sneakers-the-rat opened this issue Apr 17, 2024 · 1 comment
Open

Contribution process for JOSS code and policies #1335

sneakers-the-rat opened this issue Apr 17, 2024 · 1 comment

Comments

@sneakers-the-rat
Copy link
Contributor

Continuing a discussion from slack:

When this was merged, it caused a good deal of confusion, and it became clear that we need a bit more structure around changes to the code that runs joss, and while we're at it I think we might also want to make a process for proposing changes to policies as well since the distinction between policy and code can sometimes blur together given the nature of the journal.

This is a discussion issue to gather what we might want in a more formal proposal for a contribution policy, so it will be a bit barebones to start, but the initial thing I think we want is...

  • For any PR that makes substantive changes, announce in either joss or development slack channel (which do we want?) and give 1 week comment time for everyone to be able to review. Bugfixes or other PRs that don't meaningfully change the code don't need the 1 week review time.
  • ...? (comment below and i'll add them here)
@arfon
Copy link
Member

arfon commented Apr 20, 2024

Sounds like a reasonable plan to me @sneakers-the-rat !

Additions:

  • We probably some kind of proviso that for dev changes, you need a 👍 from one or more of @openjournals/dev .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants