Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API custom errors in domain layer contain wrong type (intent/event mixing) SP 1 #1106

Open
mayrmartin opened this issue Apr 19, 2022 · 3 comments
Open

API custom errors in domain layer contain wrong type (intent/event mixing) SP 1 #1106

mayrmartin opened this issue Apr 19, 2022 · 3 comments
Labels
api Indicates api related issue or feature bug Something isn't working good first issue Good for newcomers low Label for nice to have features which are low prio
Projects
TruBudget Support & Development
Milestone
Technical Backlog

Comments

@mayrmartin
Copy link
Collaborator

mayrmartin commented Apr 19, 2022 •
edited
Loading

Description 😯

The custom errors in the domain layer of the API do not return the desired "type". The error should not be of type event but rather of type intend.

Have a look at:
@mayrmartin mayrmartin added bug Something isn't working good first issue Good for newcomers labels Apr 19, 2022
@mayrmartin mayrmartin added this to the TruBudget 2.0.0 milestone Apr 19, 2022
@issuelabeler issuelabeler bot added the api Indicates api related issue or feature label Apr 19, 2022
@Stezido
Copy link
Contributor

Stezido commented May 5, 2022

TODOs:

  • Change return type to intent in all domain layer errors

@Stezido Stezido changed the title API custom errors in domain layer contain wrong type (intend/event mixing) API custom errors in domain layer contain wrong type (intend/event mixing) SP 1 May 5, 2022
@egdmrsy egdmrsy self-assigned this May 9, 2023
@galethil galethil added this to To Do in TruBudget Support & Development via automation Mar 14, 2024
@galethil
Copy link
Collaborator

@mayrmartin can you provide more details and if issue is still relevant pls?

@mayrmartin
Copy link
Collaborator Author

As far as I can remember, this is a naming/wording issue - on the current main it's easier to see. The error message in its current implementation gets thrown if intents are not applicable - not if events are not applicable.

@jzakotnik jzakotnik changed the title API custom errors in domain layer contain wrong type (intend/event mixing) SP 1 API custom errors in domain layer contain wrong type (intent/event mixing) SP 1 Jul 11, 2024
@jzakotnik jzakotnik added the low Label for nice to have features which are low prio label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Indicates api related issue or feature bug Something isn't working good first issue Good for newcomers low Label for nice to have features which are low prio
Projects
TruBudget Support & Development
Status: To Do
TruBudget Support & Development
To Do
Milestone
Technical Backlog
Development

No branches or pull requests
5 participants
@jzakotnik @Stezido @galethil @mayrmartin @egdmrsy