Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall target implementation has hard coded module paths #44

Closed
tfoote opened this issue Nov 20, 2010 · 3 comments
Closed

Uninstall target implementation has hard coded module paths #44

tfoote opened this issue Nov 20, 2010 · 3 comments
Labels

Comments

@tfoote
Copy link
Contributor

tfoote commented Nov 20, 2010

"""
configure_file(
"${CMAKE_SOURCE_DIR}/Modules/UninstallTarget.cmake.in"
"${CMAKE_CURRENT_BINARY_DIR}/UninstallTarget.cmake"
IMMEDIATE @only)
""""
These lines mean that I cannot include this package as a subdir of a larger CMake build, for it now looks at a higher level.

@qdot
Copy link
Member

qdot commented Nov 20, 2010

We should be able to change CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR and have this work, correct?

@qdot
Copy link
Member

qdot commented Nov 20, 2010

Also, if you're going to try implementing this in a larger repo, i'm seeing things in examples and lib CMakeLists.txt that may give you problems. We'll probably need to move the INCLUDE_DIRECTORIES calls up to the root and use CMAKE_CURRENT_SOURCE_DIR on those.

@tfoote
Copy link
Contributor Author

tfoote commented Nov 20, 2010

CMAKE_CURRENT_SOURCE_DIR works. I'm closing this and I'll open a separate pull request. For reference sha: ca531ee I've opened a pull request now #46

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants