Documenting our new code review process

[itsrachelfish]

@allanon and I have been discussing changes we'd like to see in regards to the way that code is submitted into the project. When we were using SVN, anyone with commit access would write code and push it up whenever they felt like it. There was rarely any communication between developers before changes were made or even testing done on different platforms / servers.

We'd like to make the entire development process more reliable and transparent by utilizing pull requests here on GitHub. So far we've already started using it amongst ourselves, but official documentation should be written to replace the old SVN guides like these:

http://wiki.openkore.com/index.php/Patches_Welcome
http://wiki.openkore.com/index.php/Development_Conventions

tldr; Don't push to master. Make a pull request and have it approved by another developer first.

[windhamwong]

I love the idea but pushing to branch may affect the updates for servers.
The reviewing process is good only when all of our developers are active however we all know that we are so busy on other things and rarely updating or reviewing the codes and the system.

[itsrachelfish]

@windhamwong I have added you as a developer to the project, however I'd still ask that you use the same process as everyone else and submit pull requests to be approved by another developer.

I understand that twRO might not have very many active developers to test, but someone else should at least read your changes before they're merged into master. In the past we've run into situations where a "fix" on one server will break support on others. The review process is intended to prevent that or at least catch it before it gets pushed out to non-developer users.

Things might change in the future when the project has more automated tests in place, but for now please don't push things without talking to anyone else first.

ps: If you ever need to get in touch, the #OpenKore IRC channel on freenode has been pretty active lately.

[windhamwong]

nice. I will join irc later today.
I will just create a twRO branch for updating changes here.

[lututui]

Redirected "Current Development" link to pull requests

http://openkore.com/index.php?title=Template:Index/MainLinks&curid=963&diff=3698&oldid=3687