Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom network provider #111

Closed
wants to merge 1 commit into from

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Dec 30, 2022

Ⅰ. Describe what this PR does

Based on lua script, it supports custom crd network provider, for examples: Istio VirtualService, Apisix ApisixRoute

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #111 (78f26c8) into master (3165f4e) will increase coverage by 0.38%.
The diff coverage is 60.57%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   45.63%   46.01%   +0.38%     
==========================================
  Files          39       40       +1     
  Lines        3938     4042     +104     
==========================================
+ Hits         1797     1860      +63     
- Misses       1843     1869      +26     
- Partials      298      313      +15     
Flag Coverage Δ
unittests 46.01% <60.57%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/trafficrouting/manager.go 50.81% <0.00%> (-2.33%) ⬇️
pkg/trafficrouting/network/custom/custom.go 65.62% <65.62%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

"context"
"encoding/json"
"fmt"
"k8s.io/apimachinery/pkg/api/errors"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 2 similar findings have been found in this PR


goimports: File is not goimports-ed


🔎 Expand here to view all instances of this finding
File Path Line Number
pkg/trafficrouting/network/custom/custom_test.go 22
pkg/trafficrouting/manager.go 22

Visit the Lift Web Console to find more details in your report.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@kruise-bot
Copy link

@zmberg: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zmberg zmberg closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants