Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reconfiguration #97

Merged
merged 11 commits into from Nov 8, 2020
Merged

Implement reconfiguration #97

merged 11 commits into from Nov 8, 2020

Conversation

craig-openlaw
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #97 into master will increase coverage by 0.89%.
The diff coverage is 92.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   78.80%   79.69%   +0.89%     
==========================================
  Files          16       17       +1     
  Lines         750      788      +38     
  Branches      186      190       +4     
==========================================
+ Hits          591      628      +37     
- Misses        159      160       +1     
Impacted Files Coverage Δ
contracts/helpers/FlagHelper.sol 100.00% <ø> (+12.50%) ⬆️
contracts/adapters/voting/OffchainVoting.sol 58.10% <66.66%> (ø)
contracts/adapters/Managing.sol 94.28% <85.71%> (-2.15%) ⬇️
contracts/adapters/Configuration.sol 96.00% <96.00%> (ø)
contracts/adapters/Onboarding.sol 94.66% <100.00%> (+0.14%) ⬆️
contracts/adapters/voting/Voting.sol 93.54% <100.00%> (ø)
contracts/core/DaoRegistry.sol 77.87% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838ec5d...7d4500c. Read the comment docs.

contracts/adapters/Configuration.sol Outdated Show resolved Hide resolved
contracts/adapters/Configuration.sol Outdated Show resolved Hide resolved
contracts/adapters/Managing.sol Outdated Show resolved Hide resolved
contracts/adapters/Managing.sol Outdated Show resolved Hide resolved
contracts/adapters/Onboarding.sol Outdated Show resolved Hide resolved
@craig-openlaw craig-openlaw marked this pull request as ready for review November 6, 2020 14:42
@adridadou adridadou merged commit fed843b into master Nov 8, 2020
@fforbeck fforbeck deleted the implement-reconfiguration branch November 12, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants