Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayerGroups basic raster sync #27

Closed
klokan opened this issue Aug 13, 2014 · 8 comments · Fixed by #88
Closed

LayerGroups basic raster sync #27

klokan opened this issue Aug 13, 2014 · 8 comments · Fixed by #88
Milestone

Comments

@klokan
Copy link
Member

klokan commented Aug 13, 2014

Cesium does not support concept of layer groups.

Basic raster synchronization as described in #10 iterates on in the list of OL3 layers - unsupported layers are ignored (LayerGroup is now one of them).

If LayerGroup should be supported we must include listeners on the childern of each LayerGroup in hierarchy for opacity, change of saturation, etc. and calculate the final opacity value of whole hierarchy of LayerGroups in the OLCesium wrapper.

@klokan klokan added this to the RASTER milestone Aug 13, 2014
@klokan
Copy link
Member Author

klokan commented Aug 14, 2014

A simple implementation which will include all layers in the LayerGroup hierarchy will be part #25.
The layers will be added individually and information about group is not passed to Cesium.

Advanced impementation of LayerGroups with listeners on opacity/hue/.. of the whole group is to be implemented later on.
Updated: there is #93 now.

@klokan klokan removed this from the RASTER milestone Aug 14, 2014
@klokan
Copy link
Member Author

klokan commented Aug 16, 2014

The simple implementation done in f2709f2 and included in #25

@klokan klokan added bug and removed bug labels Sep 1, 2014
@ahocevar ahocevar added this to the FEATURES milestone Sep 16, 2014
@ahocevar
Copy link
Member

Note from our client: "Our application uses several layer groups to make z-indexing and layer management very straightforward. The layer synchronization in ol3cs should be listening to change events from layer groups so layers stay synchronized between the map/globe."

@klokan
Copy link
Member Author

klokan commented Sep 19, 2014

Basic implementation for syncing layers which are inside of a LayerGroup has been done.
This is fully according the specification from #10.

Advanced implementation of LayerGroups - which would allow changes of opacity of a LayerGroup - influencing opacity on all individual layers inside of a group goes beyond the original specification.

@ahocevar - is there a bug report from the client on existing implementation of the LayerGroups?

@klokan klokan changed the title LayerGroups raster sync LayerGroups basic raster sync Sep 22, 2014
@klokan
Copy link
Member Author

klokan commented Sep 22, 2014

Closing this ticket - if the advanced "Visibility & opacity of LayerGroups" should be implemented lets create a new ticket for that...
Updated: there is #93 now.

@klokan klokan closed this as completed Sep 22, 2014
@schmidtk
Copy link
Contributor

@klokan, the issue is with collection changes on layer groups, not visibility/opacity/etc. If a layer is added to/removed from the group that change should be reflected on the globe. We aren't changing display properties at the group level so we're not concerned about that.

@klokan
Copy link
Member Author

klokan commented Sep 24, 2014

OK. It is now more clear and it belongs to this ticket. Reopening.

@klokan
Copy link
Member Author

klokan commented Oct 1, 2014

Implementation available in the PR #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants