Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linter errors #50

Closed
elemoine opened this issue Sep 16, 2014 · 3 comments
Closed

Fix Linter errors #50

elemoine opened this issue Sep 16, 2014 · 3 comments
Labels
bug
Milestone
FEATURES

Comments

@elemoine
Copy link
Member

#42 introduced lint errors. They should be fixed. And a check target should be added to the Makefile.
@elemoine elemoine added the bug label Sep 16, 2014
@elemoine elemoine added this to the FEATURES milestone Sep 16, 2014
@gberaudo gberaudo self-assigned this Sep 16, 2014
@gberaudo
Copy link
Member

Do you mean have check: lint?
Why not instead add lint to the dist target?

@elemoine
Copy link
Member Author

I like that make dist just creates a "distribution" of ol3-cesium, as its name suggests. So I'd suggest to add a check target that runs the linter(s), the compiler, and possibly performs other checks. This target would be the one we run on Travis CI. The all target could be an alias to check (it is an alias to serve today).

@elemoine
Copy link
Member Author

I'm seeing other issues in the Makefile. I'll create a PR tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
FEATURES
Development

No branches or pull requests
2 participants
@elemoine @gberaudo