Target for attribution links differs between maps #2616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (for instance Bing maps terms of use) the attribution link is opened in a new tab or window (target=_blank) while in other cases (like OSM) the links open in the same window.
I think they should all open in a new window (or all NOT in a new window if that is what is preferred). At least it should be the same for every map. Maybe the best option would be to make it a choice whether you want the attribution links to open in a new window.