Upgrade closure library version #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return [eventPosition.x, eventPosition.y]; | ||
| } | ||
| var eventPosition = goog.style.getRelativePosition(event, this.viewport_); | ||
| return [eventPosition.x, eventPosition.y]; |
There was a problem hiding this comment.
We use event.changedTouches when it is defined. google/closure-library@116609a does not use changedTouches so I'm a bit uncertain that this commit really fixes the problem for us.
There was a problem hiding this comment.
You're right; the change in closure-library in wrong. It always return [0, 0] for touchend events.
fredj
force-pushed
the
closure-lib-upgrade
branch
3 times, most recently
from
c60a7d9
to
ade15d7
Compare
fredj
force-pushed
the
closure-lib-upgrade
branch
from
ade15d7
to
926c21e
Compare
|
Is this ready to be merged from your point of view? |
|
No because of google/closure-library#343 |
fredj
force-pushed
the
closure-lib-upgrade
branch
from
926c21e
to
20ce664
Compare
|
Small clarification: the closure-library issue mentioned above don't occur with the latest closure-compiler version (closure-util >= 0.20.0) |
|
So I think we can merge this. Thanks! |
|
ok. thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove a workaround fixed upstream.
work in progress