ol.layer.Vector.getSource return type specialisation.

[gberaudo]

Avoid having to cast to ol.source.Vector.

[fredj]

+1

[elemoine]

What about Tile and Image? We need to do the same there as well.

[fredj]

ol.layer.Tile#getSource() and ol.layer.Image#getSource() return type is already a ol.source.Source so there's nothing to do.

[elemoine]

ol.layer.Tile#getSource() and ol.layer.Image#getSource() return type is already a ol.source.Source so there's nothing to do.

My understanding is that @gberaudo wants getSource to be annotated with more specific return types. This is to avoid type-casts in his compiled code. His patch changes ol.layer.Vector#getSource's return type from ol.source.Source to ol.source.Vector. Likewise, ol.layer.Image#getSource's return type should be changed to ol.source.Image.

Also, with that I think we also can remove a number of type-casts in the ol3 code. Here are two example for ol.layer.Vector#getSource: https://github.com/openlayers/ol3/blob/master/examples/gpx.js#L99 and https://github.com/openlayers/ol3/blob/master/src/ol/renderer/canvas/canvasvectorlayerrenderer.js#L171.

[fredj]

But ol.layer.Image constructor take a ol.source.Source as argument (param type is olx.layer.LayerOptions)

[elemoine]

That's a mistake I think. An ol.layer.Image instance should be configured with an ol.source.Image instance.

[fredj]

That's a mistake I think. An ol.layer.Image instance should be configured with an ol.source.Image instance.

New PR to come

[fredj]

Unnecessary type cast removed here: fredj@b88e52c

[fredj]

PR updated, thanks for any review

[elemoine]

This looks good. +1 for merging. We should also merge #2656 after this one.