Delegate transformation in ol.source.FormatVector#readFeatures to ol.format.*
#2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| return features; | ||
| return format.readFeatures(source, { featureProjection: projection }); |
There was a problem hiding this comment.
Minor but I don't think we use a space after { and before {. Do the linters complain w/o the spaces?
There was a problem hiding this comment.
No they don't, it's just a personal preference. I'll push an updated commit.
There was a problem hiding this comment.
We could switch to jscs instead of jshint to enforce this preference.
|
I added a.minor comment. Otherwise looks good to me. |
eriktim
force-pushed
the
delegate-transformation
branch
from
b3f4093
to
f9e6cd2
Compare
eriktim
force-pushed
the
delegate-transformation
branch
from
f9e6cd2
to
1da5be6
Compare
|
Thanks. |
elemoine
pushed a commit
that referenced
this pull request
Sep 1, 2014
Delegate transformation in ol.source.FormatVector#readFeatures to `ol.format.*`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2604.