ol.FeatureOverlay: use the feature style if defined #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
force-pushed
the
featureoverlay-style
branch
from
55cc6fd
to
e775c01
Compare
| styles = featureStyleFunction.call(feature, resolution); | ||
| } else { | ||
| styles = styleFunction(feature, resolution); | ||
| } |
There was a problem hiding this comment.
Minor, but you could use the ternary notation here.
There was a problem hiding this comment.
I wanted to avoid to call the function twice
There was a problem hiding this comment.
styles = goog.isDef(featureStyleFunction) ?
featureStyleFunction.call(feature, resolution) : styleFunction(feature, resolution);
|
It looks good to me. But this makes me realize that we have other inconsistencies. For example the |
New PR to come |
Same behavior as ol.layer.Vector
fredj
force-pushed
the
featureoverlay-style
branch
from
e775c01
to
9a23778
Compare
fredj
added a commit
that referenced
this pull request
Sep 3, 2014
ol.FeatureOverlay: use the feature style if defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have the same be behavior as ol.layer.Vector: feature or feature overlay or ol.style.defaultStyleFunction.