Add TextStyle offsets getters to API. #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,13 +64,13 @@ ol.style.Text = function(opt_options) { | |||
|
|
|||
| /** | |||
| * @private | |||
| * @type {number} | |||
| * @type {!number} | |||
There was a problem hiding this comment.
This is not necessary. See https://developers.google.com/closure/compiler/docs/js-for-compiler?hl=fr#nonnull.
There was a problem hiding this comment.
Thank you for the information @elemoine.
I updated the PR.
|
Agree on adding |
The other properties getters are in the API already.
gberaudo
force-pushed
the
export_text_style_offsets
branch
from
b097c58
to
9adb128
Compare
elemoine
pushed a commit
that referenced
this pull request
Sep 3, 2014
Add TextStyle offsets getters to API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other properties getters are in the API already.