-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ol.Observable#dispatchChangeEvent() to #changed() #2684
Conversation
ee38dc0
to
60a3a6c
Compare
Since dispatchChangeEvent does not only dispatch a change event, but also increases the revision counter, the method name should reflect this.
60a3a6c
to
ebe3b48
Compare
I honestly don't think this change buys us much. How about adding a |
@elemoine this is also something that came to my mind last night, although I was thinking to name it |
Having a |
Does anyone else have an opinion on this? @bartvde, the re-render use case aside, what do you think? You were the one who suggested a name change in the first place. |
As I said already I don't think this change buys us too much. I know |
Rename ol.Observable#dispatchChangeEvent() to #changed()
Since dispatchChangeEvent does not only dispatch a change event, but
also increases the revision counter, the method name should reflect
this.