Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector rendering with the DOM renderer #2690

Merged
merged 2 commits into from
Oct 23, 2014

Conversation

ahocevar
Copy link
Member

@ahocevar ahocevar commented Sep 7, 2014

This change makes vector rendering work with the DOM renderer. It includes support for vector layers, feature overlays and custom rendering using precompose/render/postcompose events. A 2D canvas is used for rendering vectors with the DOM map renderer.

@ahocevar ahocevar force-pushed the layer-vectoroverlay branch 3 times, most recently from 5d5aa7a to 19d943e Compare September 8, 2014 00:02
@ahocevar ahocevar changed the title FeatureOverlay on ol.layer.Vector and ol.source.ImageVector FeatureOverlay with DOM renderer Sep 8, 2014
@ahocevar
Copy link
Member Author

ahocevar commented Sep 8, 2014

Work in progress. As discussed with Eric and Tim, I will change this pull request so vector layers can be rendered with the DOM renderer.

@elemoine
Copy link
Member

elemoine commented Sep 9, 2014

@ahocevar cool. I'm looking forward to seeing the DOM renderer draw vector layers using Canvas. Note that there already is a case where the canvas vector layer renderer uses its own (intermediate) canvas. See https://github.com/openlayers/ol3/blob/master/src/ol/renderer/canvas/canvasvectorlayerrenderer.js#L87-L92. This is used in the case of heatmap layers.

Also, I have a branch that makes it possible to bind a feature overlay to a layer (of any type): https://github.com/elemoine/ol3/compare/featureoverlay. So with this you can use a feature overlay to draw features above a given layer. This is quite similar to this PR's current branch.

@ahocevar ahocevar changed the title FeatureOverlay with DOM renderer Vector rendering with the DOM renderer Oct 9, 2014
@ahocevar
Copy link
Member Author

ahocevar commented Oct 9, 2014

This is now ready for review.

@elemoine elemoine added this to the v3.1.0 milestone Oct 10, 2014
@elemoine
Copy link
Member

This looks good to me. +1 for merging this.

ahocevar added a commit that referenced this pull request Oct 23, 2014
Vector rendering with the DOM renderer
@ahocevar ahocevar merged commit 4596799 into openlayers:master Oct 23, 2014
@ahocevar ahocevar deleted the layer-vectoroverlay branch October 23, 2014 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants