Use pool thread for calling bin/check-example.js.

[gberaudo]

Saves 50s out of 60s on my machine, that is 83%.
Fixes #2695

[marcjansen]

This looks great at first sight. I'll give this a proper review soon. Thanks!

[marcjansen]

I can confirm this massively speeds up ./build.py check-examples & think this is a great addition.

Please remove the print('Holl')-line and add a little bit of documentation to the ThreadPool class.

It'd be extra nice if someone could test this enhancement on windows, but I guess it'll just work. It looks as if we do not have a CLA from you, @gberaudo, is that right?

I am plus one on merging this.

[gberaudo]

I updated the PR with comments and a fix for handling exceptions correctly.
I am working at CamptoCamp, I guess they have signed the corporate CLA, right?

[marcjansen]

Ahh... I didn't know that. Yes, CamptoCamp has a CCLA.

For the record: did you check whether this works on windows? I doubt that it'll be problematic, but ...

[gberaudo]

No Windows here, however it is just standard python.

On Thu, Sep 11, 2014 at 12:44:01AM -0700, Marc Jansen wrote:

Ahh... I didn't know that. Yes, CamptoCamp has a CCLA.

For the record: did you check whether this works on windows? I doubt that it'll be problematic, but ...

---

Reply to this email directly or view it on GitHub:
#2704 (comment)

Guillaume Beraudo
Camptocamp Engineer

[marcjansen]

Thanks for this @gberaudo.

[elemoine]

Thanks @gberaudo. Nice addition.