Dispatch an 'updatefeature' from the vector source

[fredj]

Comments welcome

[fredj]

If we now have a updatefeatureevent does it make sense to keep the change event ?

[elemoine]

The source emits a change event when a feature is changed, but also when a feature is added to the source or removed from the source. And the whole rendering process relies on change events right now, so, yes, without a major refactoring, we still need the change event type.

[gberaudo]

Working great thanks @fredj.

[ahocevar]

Nice, please merge!

[elemoine]

I agree with this change.

Making vector sources emit updatefeature events is a convenience, as a same could be achieved by listening to addfeature and removefeature on the source, and change on the individual features. But that definitely makes things easier for people.

One small thing though: wouldn't changefeature be a better name than updatefeature? By "better" I mean more consistent with our use of change everywhere else. Features emit change events so it makes sense to me that the source emits changefeature events. This is minor, but I thought I could still mention it.

[fredj]

@elemoine yes changefeature is a better name

[elemoine]

Thanks @fredj. @ahocevar if you agree as well I'll create a PR.

[ahocevar]

No strong opinion on the name, whatever sounds better to you guys.