Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export constructors and options of ol.source.Source children #2751

Merged
merged 1 commit into from
Sep 30, 2014

Conversation

gberaudo
Copy link
Member

Necessary addition to #2749.

@gberaudo
Copy link
Member Author

As the options are not in olx but simply defined using a typedef in the source file, the documentation does not contain details about the options. It may be acceptable though since these are abstract classes and the options are experimental anyway.

new ol.source.Tile(options) experimental
Name Type Description
options ol.source.TileOptions Tile source options.

If it is ok to merge as is, please let me know.
Otherwise moving these options to olx will be done when I get some time for it.
If someone else want to do it please go on.

@tschaub
Copy link
Member

tschaub commented Sep 28, 2014

Marking a @tyepdef with an @api annotation does not have the same effect as adding it to olx.js. If you do the latter, we get minified property names when compiling together with the application and preserved names when compiling the standalone library. With the changes here, you don't get that.

@elemoine
Copy link
Member

When a @typedef is marked with an @api marker a href link is associated to that type in the API doc. But that link will not refer to anything useful in the API doc. So I think the rule is do not mark a @typedef with an @api annotation if the @typedef is not in olx.js.

@elemoine
Copy link
Member

As the options are not in olx but simply defined using a typedef in the source file, the documentation does not contain details about the options.

As I said in my previous comment, the API doc will have href links for @typedef's marked with the @api annotation. But these links will be broken. In your case, the link will be /ol.source.html#ImageOptions, but that anchor won't exist in the ol.source.html page.

It may be acceptable though since these are abstract classes and the options are experimental anyway.

The problem is that we don't make a link in the API doc but we want the typedef in the ol-externs.js file.

@elemoine
Copy link
Member

See #2765.

@gberaudo
Copy link
Member Author

Removed @api on options. Thanks @elemoine for this simple solution.
Please merge.

elemoine pushed a commit that referenced this pull request Sep 30, 2014
Export constructors and options of ol.source.Source children
@elemoine elemoine merged commit 1c7f2ad into openlayers:master Sep 30, 2014
@elemoine
Copy link
Member

Thanks for updating the patch @gberaudo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants