Type-related changes to ol.style.Image #2773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a number of type-related changes to
ol.style.Image
,ol.style.Icon
andol.style.Circle
.Mark
ol.style.Image
an@api
annotation. This makesol.style.Image
exportable, making it possible to doimageStyle instanceof ol.style.Image
in the application code.Mark
ol.style.Image#getImage
with an@api
annotation. This makes this method show up in theol-externs.js
externs file, which is necessary for application code that looks like this:We have to have the signature of
ol.style.Image#getImage
in the externs file.Give
ol.style.Circle#getImage
andol.style.Icon#getImage
more specific return types.Please review.