Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable subclassing Interaction in public API #2805

Merged
merged 1 commit into from Oct 7, 2014
Merged

Enable subclassing Interaction in public API #2805

merged 1 commit into from Oct 7, 2014

Conversation

ghost
Copy link

@ghost ghost commented Oct 7, 2014

No description provided.

@elemoine
Copy link
Member

elemoine commented Oct 7, 2014

For (ol.js) users to be able to create custom interactions, handleMapBrowserEvent must not be renamed internally in the ol.js build. And for handleMapBrowserEvent not to be renamed it should be declared in the oli.js externs file, just as setMap for controls.

But it makes sense to me to merge this PR, for users to be able to do interaction instanceof ol.interaction.Interaction in their application code.

elemoine pushed a commit that referenced this pull request Oct 7, 2014
Merge pull request #2805 from sweco-sebhar/patch-2
90fb83b 
Enable subclassing Interaction in public API
@elemoine elemoine merged commit 90fb83b into openlayers:master Oct 7, 2014
@ghost ghost mentioned this pull request Oct 7, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elemoine @sweco-sebhar