Add ol.geom.Polygon.fromExtent #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var maxX = extent[2]; | ||
| var maxY = extent[3]; | ||
| var flatCoordinates = | ||
| [minX, minY, maxX, minY, maxX, maxY, minX, maxY, minX, minY]; |
There was a problem hiding this comment.
You might as well orient these clockwise so we don't have to duplicate the array for orientedFlatCoordinates_.
There was a problem hiding this comment.
Good point. I'll change that.
|
PR updated. The coordinates passed to |
|
LGTM |
|
@tschaub, do you agree with merging this? |
|
Sounds good to me. |
elemoine
pushed a commit
that referenced
this pull request
Oct 15, 2014
Add ol.geom.Polygon.fromExtent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tonio was positive about it, so here it is. Other suggestions for the function name are welcome.