ol.source.WMTS now passes tileClass option to ol.source.TileImage #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. You'll also need to add a |
mike-mcgann
force-pushed
the
wmts-tile-class
branch
from
58b77ff
to
d54c834
Compare
|
Updated. Let me know if there is anything else. |
| @@ -5067,6 +5070,16 @@ olx.source.WMTSOptions.prototype.style; | |||
|
|
|||
|
|
|||
| /** | |||
| * tile class | |||
There was a problem hiding this comment.
While you're at could you please add more docs for tileClass, both for WMTSOptions and TileImageOptions? Thanks.
|
I've just added an additional comment. When addressed I'll merge this. Thanks! |
The constructor for ol.source.TileImage accepts an option for the tileClass, but ol.source.WMTS does not pass this to the parent. This pull request adds that in.
mike-mcgann
force-pushed
the
wmts-tile-class
branch
from
d54c834
to
5a2c206
Compare
|
Happy to help out. Documentation has been updated. |
|
Cool. |
elemoine
pushed a commit
that referenced
this pull request
Oct 15, 2014
ol.source.WMTS now passes tileClass option to ol.source.TileImage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor for
ol.source.TileImageaccepts an option for thetileClass, butol.source.WMTSdoes not pass this to the parent. This pull request adds that in.