-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move touchstart preventDefault to ol.renderer.dom.Map #2855
Conversation
The changes included in this PR does not fixes the issue but minimize the problem: it now only occurs when the renderer is dom and on touch device. |
Is it only for touch devices? I'm wondering about ie10 and the surface device. @oterral do you have any idea? |
I can test. I'll give you the feedback this morning. |
Thanks a lot @oterral. To test this, open the side-by-side example and long press the three maps: no context menu must appear. |
LGTM tested on Surface/win 8.1/IE11 and PC/win 8/IE10 Long press on Surface triggers a contextmenu event so everthing works as before. |
can we merge this one? |
I think there is a |
e72cb7e
to
c613f65
Compare
Good point, fixed. |
Also, map renderers are disposable objects, so it may make sense to implement |
`preventDefault` is called to prevent the img context menu on mobile devices.
c613f65
to
c83caa9
Compare
Let's merge this! |
Move touchstart preventDefault to ol.renderer.dom.Map
preventDefault
is called to prevent the img context menu on mobile devices.Fixes #2853