Avoid modifying map.logos_ with each frame #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
tschaub
added a commit
that referenced
this pull request
Oct 26, 2014
Avoid modifying `map.logos_` with each frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
map.logos_object is assigned to the frame state. Layer renderers then modify this (adding logos) whenrenderer.updateLogos()is called. This means logos are "append only" - if you remove a layer, its source's logo will not be removed.This can be reproduced by opening the MapQuest example and running the following:
Though it is hard to see (because the logos also become tiny), the logo is still in the DOM.