-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetFeatureInfo format #2889
Conversation
@@ -0,0 +1,139 @@ | |||
goog.provide('ol.format.GetFeatureInfo'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would add WMS to the name for clarity, so WMSGetFeatureInfo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @bartvde. And we may add a WMTSGetFeatureInfo
format in the future.
I agree and I've updated the format name to |
Hi guys. Any objection to merge this ? |
Wow, I have been looking for this for weeks! Thank you very much @fgravin, this really makes a difference for me. When is it going to be merged? |
|
||
/** | ||
* @private | ||
* @type {ol.format.GMLBase} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not ol.format.GML2
?
It looks good to me. I've just added a few pretty minor comments. |
It looks good to me. Please merge. |
*/ | ||
ol.format.WMSGetFeatureInfo.prototype.readFeaturesFromNode = | ||
function(node, opt_options) { | ||
var options = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.featureType
and this.featureNS
are never defined on ol.format.WMSGetFeatureInfo
, it's very strange that the compiler does not trigger an error.
This PR proposes to add a format reader for WMS GetFeatureInfo request.
The format is able to read WMS GetFeatureInfo responses that starts with
<msGMLOutput>
or<FeatureCollection>
.It is based on
ol.format.GML2
format to read the features.