Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetFeatureInfo format #2889

Merged
merged 7 commits into from
Nov 27, 2014
Merged

Add GetFeatureInfo format #2889

merged 7 commits into from
Nov 27, 2014

Conversation

fgravin
Copy link
Contributor

@fgravin fgravin commented Oct 28, 2014

This PR proposes to add a format reader for WMS GetFeatureInfo request.

The format is able to read WMS GetFeatureInfo responses that starts with <msGMLOutput> or <FeatureCollection>.

It is based on ol.format.GML2 format to read the features.

@@ -0,0 +1,139 @@
goog.provide('ol.format.GetFeatureInfo');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would add WMS to the name for clarity, so WMSGetFeatureInfo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @bartvde. And we may add a WMTSGetFeatureInfo format in the future.

@fgravin
Copy link
Contributor Author

fgravin commented Nov 4, 2014

I agree and I've updated the format name to WMSGetFeatureInfo as you suggested.

@fgravin
Copy link
Contributor Author

fgravin commented Nov 12, 2014

Hi guys.

Any objection to merge this ?

@Delawen
Copy link
Contributor

Delawen commented Nov 20, 2014

Wow, I have been looking for this for weeks! Thank you very much @fgravin, this really makes a difference for me.

When is it going to be merged?


/**
* @private
* @type {ol.format.GMLBase}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ol.format.GML2?

@elemoine
Copy link
Member

It looks good to me. I've just added a few pretty minor comments.

@elemoine
Copy link
Member

It looks good to me. Please merge.

tonio added a commit that referenced this pull request Nov 27, 2014
@tonio tonio merged commit ed4bae0 into openlayers:master Nov 27, 2014
@tonio tonio deleted the getFeatureInfo branch November 27, 2014 09:30
*/
ol.format.WMSGetFeatureInfo.prototype.readFeaturesFromNode =
function(node, opt_options) {
var options = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.featureType and this.featureNS are never defined on ol.format.WMSGetFeatureInfo, it's very strange that the compiler does not trigger an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants