Don't pass an object to goog.dom.createDom for the class name #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Did you mean to base 3313338 on master? |
yes |
If the second argument to goog.dom.createDom is a string, then this is the className of the new element.
fredj
force-pushed
the
simplify-createDom
branch
from
3313338
to
6ca1640
Compare
fredj
added a commit
that referenced
this pull request
Oct 30, 2014
Don't pass an object to goog.dom.createDom for the class name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the second argument to goog.dom.createDom is a string, then this is the className of the new element. No need to create an object.
Depends on #2781