Move font-family customization to layout.css #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
force-pushed
the
remove-font-family
branch
from
546470f
to
d4bd5f2
Compare
|
Thanks for any review |
|
Not sure if this is a good idea. The default font (serif on most browsers) really does not look good inside the map. An alternative would be to set a font-family on |
|
I imagine most people who don't want the browser default will set the font-family on the body already. I think removing the font-family from our CSS is the way to go. |
|
Good point that @tschaub is making. |
|
ok to merge this PR? (side note: I'm no longer using the css from ol3 in my customer project so I don't care that much about this change) |
|
+1 |
fredj
added a commit
that referenced
this pull request
Nov 17, 2014
Move font-family customization to layout.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't force a font-family at the library level, move it to
resources/layout.css(used by the examples)