Deselect ovelapping features is broken #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request attached. |
| @@ -154,7 +154,7 @@ ol.interaction.Select.prototype.handleMapBrowserEvent = | |||
| } | |||
| } else { | |||
| // Modify the currently selected feature(s). | |||
| var /** @type {Array.<number>} */ deselected = []; | |||
| var /** @type {Array.<ol.Feature>} */ deselected = []; | |||
There was a problem hiding this comment.
You'll need to also push the feature onto the deselected array (the index is still pushed), right?
Bummer that neither the compiler nor our tests catch this.
There was a problem hiding this comment.
Bummer indeed. What are type annotations for when the compiler does not check against them? And then of course the other shortcoming is that we don't have unit tests at all for the select interaction.
|
Thanks for quick response! Any idea when this fix will end up in a release? I'm working on an open source and open data application that handles parking facilities: https://github.com/HSLdevcom/parkandrideAPI/blob/gates/application/src/main/frontend/src/app/facilities/facilityMap.js |
ahocevar
added a commit
that referenced
this pull request
Nov 13, 2014
Fix unselection of selected features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Select in a toggle mode, clicking a point where there’s overlapping selected features, results in “Uncaught TypeError: Cannot read property 'closure_uid_xxxxxxx’ of undefined” from goog.getUid.
There appears to be a bug in Select.handleMapBrowserEvent: Deselected array containing matching feature indexes is iterated in reverse order and features are removed by this index. It assumes that deselected indexes are in ascending order as to remove them starting from the end of features collection, but as it happens, the indexes are actually in descending order and it starts to remove them from the start of the collection and runs into undefined halfway through when all features overlap.