Correct olx.style.RegularShapeOptions definition #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @elemoine |
| * radius: (number|undefined), | ||
| * radius1: (number|undefined), | ||
| * radius2: (number|undefined), | ||
| * angle: (number|undefined), |
There was a problem hiding this comment.
You also need to change the @type in the definitions of the options further down in the file.
|
I added a comment, but it otherwise looks good to me. Please merge when my comment is addressed. Thanks a lot for following up on this Bart! |
bartvde
added a commit
that referenced
this pull request
Nov 29, 2014
Correct olx.style.RegularShapeOptions definition (r=@elemoine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either radius or radius1 needs to be provided. Radius2 is optional, as well as angle.