Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update attribution CSS #2803 #3038

Merged
merged 3 commits into from Dec 19, 2014
Merged

Update attribution CSS #2803 #3038

merged 3 commits into from Dec 19, 2014

Conversation

acanimal
Copy link

@fredj
Copy link
Member

fredj commented Dec 15, 2014

In fact you can completely remove max-width (tested on chrome and firefox)

@elemoine
Copy link
Member

@acanimal have you tried to remove max-width completely as suggested by @fredj? If so could you please update the PR. We need this for the 3.1 release. Thanks!

@acanimal
Copy link
Author

Sorry for the delay.

As @fredj says, it is unnecessary the max-width at .ol-attribution ul because it is set at the parent .ol-attribution so by default it uses the 100%.

I have updated the PR.

bartvde added a commit that referenced this pull request Dec 19, 2014
@bartvde
Merge pull request #3038 from acanimal/master
3bc84c7 
Update attribution CSS #2803
@bartvde bartvde merged commit 3bc84c7 into openlayers:master Dec 19, 2014
@tschaub tschaub mentioned this pull request Dec 20, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acanimal @fredj @elemoine @bartvde