Add tooltip to show measure + help message while drawing #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice example! I added some minor comments. |
4 tasks
pgiraud
force-pushed
the
measure_tooltip
branch
from
1b10e9e
to
675044c
Compare
pgiraud
force-pushed
the
measure_tooltip
branch
from
675044c
to
c63c358
Compare
|
This is minor but don't you think we should change the style of the draw interaction's feature overlay? I find the "blue" too flashy for a measure tool. Yeah, certainly subjective. |
|
This is great! With or without toning down the blue, I'm in favor or merging. |
|
I changed the styling a bit. Merging. |
pgiraud
pushed a commit
that referenced
this pull request
Feb 5, 2015
Add tooltip to show measure + help message while drawing
|
I love the new styling! Very nice work. |
|
how to show tooltip when drawing a geom.circle? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to update the measure example to show how to show the measurement while drawing. It relies on
ol.Overlay.Here's how it looks:
Please review.