-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support on disk GeoWebCache tilecaches #3241
Conversation
Added example data and made zeroPad private. Thanks for the suggestions @tsauerwein. |
I think this is ready for review, but I cannot change the pull request title to remove [wip]. |
Note that the build fails on Travis. |
Fixed now. |
LGTM. Does anyone from Boundless interested in reviewing this? Are preseeded GWC caches common and actually used in practice? I have no opinion, just asking. |
I think this is useful @elemoine so you have reviewed the code already? If so, I think we should merge this in? |
|
||
|
||
/** | ||
* Layer name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a dot at end of line. We use punctuation elsewhere.
@bartvde I added comments, but I think I have more. |
@elemoine cool TIA it wasn't clear to me if you had already reviewed (since you said LGTM) |
I had looked at it, but another look actually raised comments :-) |
Thanks for the double review @elemoine :) Should be amended now. |
Hang on, gjslint didn't like my @Private additions. I'll try to fix that and update. |
My last comment would be about support for multi-domain URLs, which other tile image sources support. |
Looking at how other tiled sources works with URLs it might be possible to rewrite this PR to use ol.TileUrlFunction.createFromTemplate and friends and in the process get support for multi-domain URLs. |
Exactly. |
Closing due to lack of activity. Also, the way we create tile urls has changed since. @bjornharrtell, please reopen if you are able/willing to continue working on this. And sorry for letting your valuable work go unnoticed for such a long time. |
This PR provides a Source that can read tiles directly from a preseeded GeoWebCache cache dir that has been exposed on a webserver.
Adapted from @tschaub's experimental code for OpenLayers 2 here:
http://dev.openlayers.org/sandbox/tschaub/gwc/lib/OpenLayers/Layer/GeoWebCache.js