Remove ol.format.BinaryFeature #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok for me, but I think it would be nice that the removal of the binary format be done with one commit or consecutive commits, to make it easier for someone who wants to find back the old binary format code. |
|
externs/vbarray.js can be removed as well |
|
+1 on the removal as well |
|
@tschaub see https://github.com/tschaub/ol3/compare/unbinary...fredj:unbinary for the |
|
@tschaub You can find a rebased branch here: master...fredj:unbinary |
|
Thanks for the extra commits @fredj. I think this is good to go now. Anybody else? |
|
I'm taking previous comments as a sign that this is good to merge. |
tschaub
added a commit
that referenced
this pull request
Apr 19, 2015
Remove ol.format.BinaryFeature.
elemoine
added a commit
to openlayers/openlayers-closure-application
that referenced
this pull request
Aug 3, 2015
This file was removed with openlayers/openlayers#3516. Fixes #1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm excited to have parsers for binary encodings, but this code is neither tested nor used currently. And the addition of
ArrayBufferto theol.format.Feature#readFeaturemethods is misleading (see also #3515). Since this will forever be in our history, when we do have a specific implementation of a feature format for binary encodings, the author can decide if there is utility in this code.There's more that can be removed after #3481 is in (specifically
ol.format.FormatType.BINARYand related code in the feature loader).