Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ol.format.WFS.writeGetFeature() - JS error (relase version) #3713

Merged
merged 1 commit into from Jun 8, 2015
Merged

ol.format.WFS.writeGetFeature() - JS error (relase version) #3713

merged 1 commit into from Jun 8, 2015

Conversation

bartvde
Copy link
Member

@bartvde bartvde commented Jun 8, 2015

calling writeGetFeature for ol.format.WFS

Cannot read property 'length' of undefined

v3.5.0

@kulmegil kulmegil changed the title Debug / relase js errors ol.format.WFS.writeGetFeature() - JS error (relase version) Jun 2, 2015
@harrio
Copy link

harrio commented Jun 4, 2015

I'm using OL3 with ClojureScript and I've run into the same kind of problem but with ol.format.GeoJSON. When I call readFeatures this same error occurs somewhere in ol.geom.SimpleGeometry. The coordinates seem to come there undefined. The same code works fine if the code is not optimized.

@bartvde
Copy link
Member

bartvde commented Jun 4, 2015

Can anybody post a simple JSFiddle to reproduce this?

@harrio
Copy link

harrio commented Jun 5, 2015

My problem doesn't seem to be related to this after all, as I was able to use the same features in plain Javascript and with the minified 3.5.0 ol3.js without a hitch.

@kulmegil
Copy link
Author

kulmegil commented Jun 8, 2015

no error (debug, v3.6.0)
https://jsfiddle.net/tn74jgmz/

JS error (release v3.6.0)
https://jsfiddle.net/qmdLefq5/1/

@bartvde
Copy link
Member

bartvde commented Jun 8, 2015

confirmed there is an issue here

@bartvde
Copy link
Member

bartvde commented Jun 8, 2015

okay I think I have found the issue

@bartvde
Copy link
Member

bartvde commented Jun 8, 2015

PR attached, TIA for any review

@fredj
Copy link
Member

fredj commented Jun 8, 2015

LGTM

@bartvde
Copy link
Member

bartvde commented Jun 8, 2015

thanks for the review @fredj

bartvde added a commit that referenced this pull request Jun 8, 2015
Add missing propertyNames member for olx.format.WFSWriteGetFeatureOptions
@bartvde bartvde merged commit 10b54a9 into openlayers:master Jun 8, 2015
@bartvde bartvde deleted the issue-3713 branch June 8, 2015 14:15
@kulmegil
Copy link
Author

kulmegil commented Jun 8, 2015

I could use closure compiled build with this for the testing..?

@bartvde
Copy link
Member

bartvde commented Jun 8, 2015

if you build your own based on master with make build yes you can test with that, let me know if that works for you. Alternatively I can send you an ol.js file.

@kulmegil
Copy link
Author

kulmegil commented Jun 9, 2015

@bartvde
I would appreciate that.

@bartvde
Copy link
Member

bartvde commented Jun 9, 2015

@kulmegil
Copy link
Author

Working fine for me so far.

@bartvde
Copy link
Member

bartvde commented Jun 10, 2015

Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants