New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ol.format.WFS.writeGetFeature() - JS error (relase version) #3713
Conversation
I'm using OL3 with ClojureScript and I've run into the same kind of problem but with ol.format.GeoJSON. When I call readFeatures this same error occurs somewhere in ol.geom.SimpleGeometry. The coordinates seem to come there undefined. The same code works fine if the code is not optimized. |
Can anybody post a simple JSFiddle to reproduce this? |
My problem doesn't seem to be related to this after all, as I was able to use the same features in plain Javascript and with the minified 3.5.0 ol3.js without a hitch. |
no error (debug, v3.6.0) JS error (release v3.6.0) |
confirmed there is an issue here |
okay I think I have found the issue |
PR attached, TIA for any review |
LGTM |
thanks for the review @fredj |
Add missing propertyNames member for olx.format.WFSWriteGetFeatureOptions
I could use closure compiled build with this for the testing..? |
if you build your own based on master with make build yes you can test with that, let me know if that works for you. Alternatively I can send you an |
@bartvde |
Working fine for me so far. |
Thanks for the feedback. |
calling writeGetFeature for ol.format.WFS
v3.5.0