Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require projection extent for x-wrapping tile sources #3867

Merged
merged 1 commit into from Jul 3, 2015

Conversation

ahocevar
Copy link
Member

@ahocevar ahocevar commented Jul 2, 2015

#3864 causes a regression, because a tile source now requires a projection with specified extent when global is set to true. This change fixes the regression.

@ahocevar ahocevar added this to the v3.7.0 milestone Jul 2, 2015
@ahocevar
Copy link
Member Author

ahocevar commented Jul 2, 2015

This should be considered for the 3.7 release. Should be a very easy review.

@bartvde
Copy link
Member

bartvde commented Jul 3, 2015

LGTM, a test case would be good to have but I won't block you on it (or you can do it after the release, btw I plan for later in the day today (around 14:00 or 15:00 CET).

@ahocevar
Copy link
Member Author

ahocevar commented Jul 3, 2015

Tests added.

@bartvde
Copy link
Member

bartvde commented Jul 3, 2015

thanks @ahocevar please merge if Travis gives the okay

@bartvde
Copy link
Member

bartvde commented Jul 3, 2015

@ahocevar I'll wait for this one before cutting the release

ahocevar added a commit that referenced this pull request Jul 3, 2015
Do not require projection extent for x-wrapping tile sources
@ahocevar ahocevar merged commit 0690877 into openlayers:master Jul 3, 2015
@ahocevar ahocevar deleted the no-proj-extent-required branch July 3, 2015 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants