Remove unnecessary cast #4060
Merged
Remove unnecessary cast #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
force-pushed
the
unnecessary_cast
branch
2 times, most recently
from
8eae8ca
to
e386907
Compare
|
Looks good. Please merge. |
| var styleFunction; | ||
|
|
||
| if (goog.isFunction(obj)) { | ||
| styleFunction = /** @type {ol.FeatureStyleFunction} */ (obj); | ||
| styleFunction = obj; |
There was a problem hiding this comment.
The typing here and above makes sense to me. This is about making sure styleFunction is set to an ol.FeatureStyleFunction. Does the compiler complain about that when a specific flag is used?
There was a problem hiding this comment.
With the unnecessaryCasts check enabled, the error is:
ERR! compile /home/fredj/public_html/ol3/src/ol/feature.js:311: ERROR - unnecessary cast
ERR! compile from: function (this:ol.Feature, number): (Array<(null|ol.style.Style)>|null)
ERR! compile to : function (this:ol.Feature, number): (Array<(null|ol.style.Style)>|null)
ERR! compile styleFunction = /** @type {ol.FeatureStyleFunction} */ (obj);
|
I just added a minor comment. Feel free to merge. |
Found by the latest version of closure-compiler (v20150729)
fredj
force-pushed
the
unnecessary_cast
branch
from
e386907
to
529f869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by the latest version of closure-compiler (v20150729)