Load erroneous image in ol.Image#load and ol.ImageTile#load #5270
Conversation
fredj
force-pushed
the
load_error
branch
2 times, most recently
from
5b227eb
to
c488fab
Compare
| @@ -122,10 +122,11 @@ ol.Image.prototype.handleImageLoad_ = function() { | |||
|
|
|||
|
|
|||
| /** | |||
| * Load not yet loaded URI. | |||
| * Load not yet loaded or erroneous image. | |||
There was a problem hiding this comment.
I think Load the image or retry if loading previously failed. would make for clearer docs. Loading an "erroneous" image makes it sound like the intent is to load the wrong image.
There was a problem hiding this comment.
Thanks for the suggestion; I will change
fredj
changed the title
|
Ready to be reviewed, thanks |
|
@fredj Will this load ad-infinitum when e.g. connection to internet breaks? |
|
@gjn no, this only expose the load function and allow error tiles/images to be loaded again |
|
I may be missing something, but to me this looks indeed like error tiles will be retried over and over. |
This needs to be checked but ol3 doesn't retry to load tiles on error. |
|
You are right @fredj: https://github.com/openlayers/ol3/blob/v3.16.0/src/ol/tilequeue.js#L115-120 and https://github.com/openlayers/ol3/blob/v3.16.0/src/ol/reproj/tile.js#L321-L323 only call That said, this is good to merge. |
| @@ -122,10 +122,11 @@ ol.Image.prototype.handleImageLoad_ = function() { | |||
|
|
|||
|
|
|||
| /** | |||
| * Load not yet loaded URI. | |||
| * Load the image or retry if loading previously failed. | |||
There was a problem hiding this comment.
Maybe add a note that loading is taken care of by the tile queue, and calling this method is only needed for preloading or for reloading in case of an error.
|
Thanks for the review |
Allow tiles in
ol.ImageState.ERRORstate to be loaded.To be able to reload erroneous tiles.
Fixes #4338