New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept feature projection in GeoJSON constructor #5917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thnaks Tim. I have added one question, which you'll answer with ease, I guess.
Good to be merged otherwise.
return ol.obj.assign({ | ||
dataProjection: this.defaultDataProjection, | ||
featureProjection: this.defaultFeatureProjection | ||
}, options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did rightHanded
and decimals
go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If rightHanded
or decimals
are provided in option
, these will be applied to the return.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yes, I somehow didn't see the options
being passed in. Thanks for the clarification, @tschaub.
* Projection for features read or written by the format. Options passed to | ||
* read or write methods will take precedence. | ||
* @type {ol.ProjectionLike} | ||
* @api stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to mark this option stable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to call this stable. I'll merge as is, and if there is disagreement, we can change it before the release.
Thanks for the review @marcjansen and @fredj. |
@tschaub locally tests fail with make check for me:
|
I get the same error in make test. |
This adds support for a
featureProjection
option to the GeoJSON constructor.See #5687.